Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Restrict chromium requests #432

Merged
merged 8 commits into from
Aug 18, 2022
Merged

[1.0] Restrict chromium requests #432

merged 8 commits into from
Aug 18, 2022

Conversation

joshuali925
Copy link
Member

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022 •
edited
Loading

Codecov Report

Merging #432 (0190ec8) into aos-1.0.0.0-ga (60e385e) will increase coverage by 0.05%.
The diff coverage is 67.92%.

@@                 Coverage Diff                  @@
##             aos-1.0.0.0-ga     #432      +/-   ##
====================================================
+ Coverage             64.13%   64.18%   +0.05%     
  Complexity              309      309              
====================================================
  Files                   102      102              
  Lines                  4380     4420      +40     
  Branches                658      666       +8     
====================================================
+ Hits                   2809     2837      +28     
- Misses                 1403     1415      +12     
  Partials                168      168
Flag Coverage Δ
dashboards-reports 77.61% <67.92%> (-0.16%) ⬇️
reports-scheduler 53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t_definition_details/report_definition_details.tsx 69.85% <0.00%> (ø)
.../components/main/report_details/report_details.tsx 73.73% <0.00%> (ø)
...r/routes/utils/visual_report/visualReportHelper.ts 80.37% <60.60%> (-8.38%) ⬇️
...rt_definitions/report_settings/report_settings.tsx 81.97% <100.00%> (ø)
...ashboards-reports/server/routes/utils/constants.ts 100.00% <100.00%> (ø)
...ashboards-reports/server/utils/validationHelper.ts 91.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavithacm kavithacm merged commit ab585c6 into opensearch-project:aos-1.0.0.0-ga Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavithacm kavithacm kavithacm approved these changes

@ps48 ps48 ps48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshuali925 @codecov-commenter @ps48 @kavithacm @davidcui1225